#142 [feat] 버전에 따른 다이얼로그 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minemi00
approved these changes
Feb 1, 2024
Comment on lines
+77
to
+78
| private const val MAXIMUM_STORE_VERSION = "999.9.9" | ||
| private const val MAXIMUM_FORCE_VERSION = "999.0.0" |
There was a problem hiding this comment.
근데 이건 정말 단순 궁금한건데.. store 버전은 999.9.9까지고 force 버전은 999.0.0인 이유가 있나여...??
There was a problem hiding this comment.
별 이유는 없고 만약에 버전 서버 통신 이슈로 설정해둔 값이 들어가게 되면 유연한or강제 업데이트가 띄워지면 좋겠어서 했습니다!
| import javax.inject.Qualifier | ||
| import javax.inject.Singleton | ||
|
|
||
| @Module |
…store-depend-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
💬 To Reviewers